src/test/renderer/settingsSearchIndex.test.ts (1)

20-27: Consider adding a failure message for misrouted integrations.

Current assertion is correct; a message would make CI failures faster to diagnose.

🔎 Optional diagnostics improvement

-    expect(misrouted).toEqual([]);
+    expect(
+      misrouted,
+      `Integration entries must use tabId="integrations". Misrouted ids: ${misrouted
+        .map((entry) => entry.id)
+        .join(', ')}`
+    ).toEqual([]);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/test/renderer/settingsSearchIndex.test.ts` around lines 20 - 27, Add an
explicit failure message when misrouted integrations are found: after computing
misrouted (from INTEGRATION_REGISTRY and SETTINGS_INDEX) add a guard like if
(misrouted.length > 0) throw new Error(`Misrouted integrations:
${misrouted.map(m => `${m.id} (expected tabId=integrations)`).join(', ')}`) so
CI shows the specific IDs and details before the existing expect check in the
test that routes entries to the integrations tab.

src/renderer/components/SettingsSearchInput.tsx (1)

4-6: Import statement ordering is unconventional.

The isMac constant is declared between import statements, which breaks the typical import-first convention. Consider moving it after all imports:

♻️ Suggested reordering

 import React, { forwardRef } from 'react';
 import { Search, X } from 'lucide-react';
-
-const isMac = typeof navigator !== 'undefined' && /mac|iphone|ipad|ipod/i.test(navigator.platform);
 import { Input } from '@/components/ui/input';
 import { Button } from '@/components/ui/button';
+
+const isMac = typeof navigator !== 'undefined' && /mac|iphone|ipad|ipod/i.test(navigator.platform);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/renderer/components/SettingsSearchInput.tsx` around lines 4 - 6, Move the
top-level isMac constant declaration so all import statements come first;
specifically, relocate the line that defines isMac (using navigator.platform and
the /mac|iphone|ipad|ipod/i test) to appear after the imports of Input and
Button in SettingsSearchInput.tsx, preserving the same expression and any usages
of isMac elsewhere in that file.

src/renderer/components/SettingsSearchResults.tsx (2)

8-16: Consider sharing TAB_LABELS with SettingsPage.

TAB_LABELS duplicates the tab label mapping that exists implicitly in SettingsPage.tsx (in the tabs array). If tab names change, they'd need to be updated in multiple places.

This is minor since the labels are unlikely to change frequently and the duplication is small.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/renderer/components/SettingsSearchResults.tsx` around lines 8 - 16,
TAB_LABELS in SettingsSearchResults.tsx duplicates the tab-to-label mapping
already defined in SettingsPage's tabs array; to avoid drift, export the
canonical labels from SettingsPage (or a shared module) and import them into
SettingsSearchResults instead of maintaining TAB_LABELS. Update SettingsPage to
expose the mapping (e.g., export const TAB_LABELS or export the tabs array) and
replace the local TAB_LABELS usage in SettingsSearchResults.tsx with an import
of that exported symbol so both components read the single source of truth.

---

60-66: Empty state could benefit from sanitizing the displayed query.

The query is rendered directly in the empty state message. If the query contains special characters or is very long, this could cause display issues. Consider truncating long queries:

♻️ Optional: Truncate long queries in empty state

     return (
       <div className="flex flex-col items-center justify-center py-20 text-center">
-        <p className="text-sm text-muted-foreground">No settings found for "{query}"</p>
+        <p className="text-sm text-muted-foreground">
+          No settings found for "{query.length > 50 ? `${query.slice(0, 50)}…` : query}"
+        </p>
       </div>
     );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/renderer/components/SettingsSearchResults.tsx` around lines 60 - 66, The
empty-state renders the raw query in SettingsSearchResults, which can be too
long or contain problematic characters; add a small helper (e.g.,
truncateQuery(query: string, max = 50): string) and use it when rendering the
<p> so the displayed string is shortened with an ellipsis if over the limit (and
continue to rely on React's text rendering for escaping); update the JSX in
SettingsSearchResults where it currently renders `No settings found for
"{query}"` to use the truncated/sanitized value (e.g., truncated =
truncateQuery(query) and render `No settings found for "{truncated}"`).

src/renderer/components/IntegrationsCard.tsx (1)

558-561: Type assertion is safe but could be stricter.

The entry.id as IntegrationId assertion works because INTEGRATION_REGISTRY defines all valid IDs. However, if a new integration is added to the registry without adding a corresponding entry to integrationRuntime, this would compile but fail at runtime with undefined properties.

Consider adding a compile-time check or runtime guard:

♻️ Optional: Add runtime safety check

 const integrations = INTEGRATION_REGISTRY.map((entry) => ({
   ...entry,
-  ...integrationRuntime[entry.id as IntegrationId],
+  ...integrationRuntime[entry.id as IntegrationId] ?? (() => {
+    console.warn(`Missing runtime config for integration: ${entry.id}`);
+    return { logoSvg: '', connected: false, loading: false, onConnect: () => {}, onDisconnect: () => {} };
+  })(),
 }));

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/renderer/components/IntegrationsCard.tsx` around lines 558 - 561, The
code maps INTEGRATION_REGISTRY and force-casts entry.id to IntegrationId which
can mask missing keys in integrationRuntime; update the mapping to explicitly
guard or assert presence of a runtime entry: for each entry from
INTEGRATION_REGISTRY, lookup integrationRuntime[entry.id] into a local (e.g.,
runtime) and if absent either throw a clear error or merge with safe defaults
before spreading into integrations; alternatively tighten types so
INTEGRATION_REGISTRY entries are constrained to keys of integrationRuntime (use
a Record or TypeScript's satisfies/const patterns) so missing runtimes are a
compile-time error—apply this change around the integrations construction where
INTEGRATION_REGISTRY, integrationRuntime, IntegrationId, and integrations are
referenced.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes